Custom binary platforms for query engine

[divyenduz]

Recently, we implemented most parts of this spec.

Custom binaries (manually compiled) section is still to be implemented though.

[mavilein]

The required part in the Prisma schema parser is done.

[janpio]

Sync between @mavilein and @timsuchanek necessary.
Spec is not "finished enough" to start implementation, ping @divyenduz

[divyenduz]

The spec is ready now to be implemented: https://github.com/prisma/specs/tree/master/binaries#how-to-fetch-binaries-1

[divyenduz]

This majorly impacted the following:

1. Windows users (other users which we did not support yet) -> Windows the major use case is supported now
2. platforms -> binaryTargets rename -> This was suggested in the spec to avoid SEO wars with a future product that might include platforms. That is tracked here: Rename platforms to binaryTargets #553

This reduces the priority of this issue for now.

[janpio]

Internal note: Dropped as re-prioritized.

[janpio]

What exactly is not implemented here @divyenduz? ENV vars like PRISMA_QUERY_ENGINE_BINARY or the compiling part?

[divyenduz]

Yes, env vars like PRISMA_QUERY_ENGINE_BINARY are tracked by this issue, how to compile a custom binary is already documented (maybe?) I remember doing it but can't find it anymore, so maybe a separate issue for that.

Renaming (a subset of this issue), is tracked here: #553

[janpio]

Can you try to apply https://github.com/prisma/specs/blob/master/meta/specs.md#implemented-vs-not-implemented to the spec then for that? Thanks.

[timsuchanek]

Released in the latest preview.

[divyenduz]

The variables PRISMA_QUERY_ENGINE_BINARY and PRISMA_MIGRATION_ENGINE_BINARY are ignored by the CLI.

I validated this by providing an incorrect path, it should have thrown and error but it worked instead.

[janpio]

Please open a new bug report for this @divyenduz instead of reopening the feature issue.

[pantharshit00]

There is already an issue about this: #1034

I am closing this one