Prisma lift error: ambiguous self-relation detected

[iherger]

I accidentally had an error in a data model definition, which lead to a self-referencing model (related should have been pointing to a different model B, and not to A ):

model A {
  id      String @default(cuid()) @id @unique
  name    String    
  related A[] 
}

With this data model:

• the first invocation of prisma2 lift save/up was successful.
• further invocations of prisma2 lift save/up failed silently. Debugging showed the error message "Ambiguous self relation detected."

Expected behaviour:

1. at the first invocation of prisma2 lift save/up, report the "Ambiguous self relation detected." message, and prevent the creation of the ambiguous self relation.
2. don't fail silently, but actually display the error message

[pantharshit00]

Hi,

I am unable to reproduce this. The exact steps I took are:

1. prisma2 init
2. Added the model and migrated the datamodel using lift:

model A {
  id      String @default(cuid()) @id @unique
  name    String    
  related A[] 
}

3. Added the further model to the datamodel and remigrated using lift:

model B {
  id   String @default(cuid()) @id
  name String
  test Int
}

3. Deployment was successful and the underlying data structure is correct.
   

[divyenduz]

I am able to repro this: https://github.com/divyendu-test/p2-488

Thanks to a nice and shiny debugging session with @momakes

[imVinayPandya]

I am facing same issue, any solution/work around for this?

[divyenduz]

@imVinayPandya We will work on this in this sprint 👍

[perlo27]

After getting this error, is there any way to fall back?
I've tried to delete migration and change back .prisma file, but still having this error, probably it's cached somewhere?

[tomhoule]

This should be fixed by prisma/prisma-engines#82

The problem was that we weren't separating between models when validating that relation fields weren't causing any ambiguity, so there were false positives. The fix will be in the next preview :)

The PR also contains another change that makes the check for ambiguity in self relationships (model fields that refer to the same model) stricter.

Before, with this model:

model Human {
    id Int @id
    parent Human
    child Human
}

we would have inferred a single self-relation with parent and child as the two ends.

Now this model is invalid, you need to specify whether you want two self relations or one, by using @relation("NameOfTheRelation").

More info on this change in this schema spec PR: prisma/specs#201

[divyenduz]

Reopening while this is not in alpha 🙏

[abdusamadtv]

I accidentally had an error in a data model definition, which lead to a self-referencing model (related should have been pointing to a different model B, and not to A ):

model A {
  id      String @default(cuid()) @id @unique
  name    String    
  related A[] 
}

With this data model:

• the first invocation of prisma2 lift save/up was successful.
• further invocations of prisma2 lift save/up failed silently. Debugging showed the error message "Ambiguous self relation detected."

Expected behaviour:

1. at the first invocation of prisma2 lift save/up, report the "Ambiguous self relation detected." message, and prevent the creation of the ambiguous self relation.
2. don't fail silently, but actually display the error message

I had the same schema and everything was good, but today after adding some new fields I've started to get this error

Here's my schema

I tried this friends User[] @relation(name: "UserFriends") but I'm still getting error

[iaarab]

I get this error while running the prisma2 init hello-prisma and selecting photon only:

[janpio]

Both @iaarab and @AbdusamadTurdiev, please both open a new issue and include all the relevant information so that what we can reproduce and later investigate what is going on. (The individual steps how you get your schema, and the schema as text (if possible) would help a lot.)

[abdusamadtv]

is this going to be fixed guys?

[pantharshit00]

@AbdusamadTurdiev This has been fixed in the engine by prisma/prisma-engines#82 as mentioned by @tomhoule.

This hasn't been released yet so we have kept the PR open

[mavilein]

A fix for this was merged to alpha 9 days ago. It will be released as a normal preview tomorrow.
Forgot to close this.

[nhuesmann]

@mavilein I am still having this issue in prisma2@2.0.0-preview014, binary version: 188a379c9b8c6650e5812f9bdb7407d7b197692f. Preview 14 states it fixes this bug. Should I open a new issue, or post my schema here?

[mavilein]

@nhuesmann : Open a new one please 🙏

[nhuesmann]

@mavilein done: https://github.com/prisma/prisma2/issues/752