Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end testing of CLI init flows #615

Closed
janpio opened this issue Sep 27, 2019 · 1 comment
Closed

End to end testing of CLI init flows #615

janpio opened this issue Sep 27, 2019 · 1 comment
Assignees
@janpio
Labels
kind/improvement An improvement to existing feature and code. topic: old-introspection topic: prisma init CLI: prisma init
Milestone
Preview 17

Comments

@janpio
Copy link
Member

janpio commented Sep 27, 2019

We have quite a lot of different paths through prisma2 init now, which should work on all kinds of environments. Sometimes some of them break unfortunately.

I think it might be beneficial to have a e2e tests (so simulating actual user activity) on these flows, to avoid regressions in that area.

It might make sense to set this up as a new project that has its own CI (maybe not even Buildkite but Circle, AppVeyor, Azure Pipelines, Travis - whatever can serve all our platforms easily and quickly).
@divyenduz divyenduz added the kind/improvement An improvement to existing feature and code. label Sep 27, 2019
@janpio janpio self-assigned this Oct 7, 2019
@janpio janpio added this to the Preview 15 milestone Oct 11, 2019
@janpio janpio modified the milestones: Preview 15, Preview 16 Oct 28, 2019
@janpio janpio modified the milestones: Preview 16, Preview 17 Nov 7, 2019
@janpio
Copy link
Member Author

janpio commented Nov 21, 2019

This now partially exists under https://github.com/janpio/prisma2-cli-e2e-tests - as it is unclear how we will proceed with the CLI, it is also unclear how to proceed with the tests.

@janpio janpio closed this as completed Nov 21, 2019
timsuchanek added a commit that referenced this issue Apr 14, 2020
@timsuchanek
Fix deep include with orderBy
2a42e7c 
Closes #615


Former-commit-id: 686d18e
timsuchanek added a commit that referenced this issue Apr 14, 2020
@timsuchanek
Fix deep include with orderBy
4cee929 
Closes #615


Former-commit-id: 686d18e
Former-commit-id: 2a42e7c
@squirly squirly mentioned this issue Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janpio janpio

Labels
kind/improvement An improvement to existing feature and code. topic: old-introspection topic: prisma init CLI: prisma init
Projects
None yet
Milestone
Preview 17
Development

No branches or pull requests
2 participants
@janpio @divyenduz