fix: prisma2 introspect for mysql database #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ha, |
|
Thanks for the PR! This bug was not reported but I can confirm it. |
|
@divyenduz will look into both the bug and the possible fix via this PR to check if this solves the problem. |
|
Do you want me to post a before/after gif? |
|
@wardpeet That would be great thanks 🙌 |
janpio
added
bug/2-confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
prisma2 initI can create a connection with my mysql connection and get a prisma.schema generated. However when I runprisma2 introspectit gives mePlease provide a database nameerror. Schema is not necessary for mysql but it is for Postgres so I updated the statements to support MySQL as well.