Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install behavior on linux #944

Closed
timsuchanek opened this issue Nov 15, 2019 · 8 comments
Closed

Improve install behavior on linux #944

timsuchanek opened this issue Nov 15, 2019 · 8 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@timsuchanek
Copy link
Contributor

When installing prisma2 in an ordinary Ubuntu docker image, you'll get an error, that you have to install prisma2 with --unsafe-perm.
We should come up with a better solution here instead of letting the user figure the situation out.

@timsuchanek timsuchanek added the kind/improvement An improvement to existing feature and code. label Nov 15, 2019
@timsuchanek timsuchanek self-assigned this Nov 15, 2019
@LongLiveCHIEF
Copy link

@timsuchanek this is being tracked in #938. would you mind closing this in favor of that?

@timsuchanek
Copy link
Contributor Author

@LongLiveCHIEF this is just mentioning the --unsafe-perm aspect of your issue. In your issue you also mention GPG and proxies. In order to have a separate working item we can plan, I created this issue.

@divyenduz
Copy link
Contributor

npm also has docs to fix this behavior: https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally

Irrespective of Prisma, if this is not addressed on linux, users need to use sudo with npm.

@pantharshit00
Copy link
Contributor

Irrespective of Prisma, if this is not addressed on linux, users need to use sudo with npm.

Yes, but sadly most of the online tutorials encourage the use of sudo for installing global packages in Linux. Also, people want to install the CLI in docker to run the migrations and it is tedious to fix permissions there.

@LongLiveCHIEF
Copy link

As far as a docker image goes, I'd rather have a prisma2 image as a base, which already has the binaries installed globally, as opposed to starting with the base node image myself and having to figure out how to install everything.

Providing a ready made cli docker image means I only have to worry about pulling that single image, and not making sure I have connections for all the binary dependencies.

@janpio
Copy link
Member

janpio commented Nov 21, 2019

Please open a new issue for this request @LongLiveCHIEF. It is not related to the original problem and task that is being tracked here from @timsuchanek. Thanks.

@janpio janpio added this to the Preview 18 milestone Nov 22, 2019
@dodas
Copy link

dodas commented Nov 28, 2019

@LongLiveCHIEF I don't agree with your opinion.
I, in most cases, don't want to decide about docker image based on one particular library I am going to use inside it. I will much rather have some light base and then cherry-pick software I need.

Hopefully prisma can be improved to work seamlessly in either scenario.

@timsuchanek
Copy link
Contributor Author

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of prisma2.
You can try it out with npm i -g prisma2@alpha.

In case it’s not fixed for you - please let us know and we’ll reopen this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

No branches or pull requests

7 participants