Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Engine Commands) Pass JSON File to Query Engine #841

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix(Engine Commands) Pass JSON File to Query Engine #841

merged 1 commit into from
Nov 7, 2019

Conversation

williamluke4
Copy link
Contributor

@williamluke4 williamluke4 commented Oct 24, 2019 •
edited

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@williamluke4
Copy link
Contributor Author

williamluke4 commented Nov 2, 2019 •
edited

Hey @timsuchanek, @mavilein.
This should fix #254 which has now been open for months and has really been a show stopper...

This issue also depends on prisma/prisma-engines#115
prisma/prisma-engines#155 being close. Hence why I have brought @mavilein in.

I really appreciate all your work but I am reaching the end of my tether and I would love some input/feedback.

@pimeys pimeys mentioned this pull request Nov 7, 2019
Merged
@pimeys
Copy link
Contributor

pimeys commented Nov 7, 2019

Ready to close this in favor of prisma/prisma-engines#166

@pimeys
Copy link
Contributor

pimeys commented Nov 7, 2019

merged in prisma/prisma-engines#166

@pimeys pimeys closed this Nov 7, 2019
@timsuchanek timsuchanek reopened this Nov 7, 2019
@timsuchanek timsuchanek merged commit 4777561 into prisma:master Nov 7, 2019
This was referenced Nov 8, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsuchanek timsuchanek Awaiting requested review from timsuchanek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@williamluke4 @CLAassistant @pimeys @timsuchanek