Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/root class instances #39

Merged
merged 2 commits into from
May 25, 2018
Merged

Feature/root class instances #39

merged 2 commits into from
May 25, 2018

Conversation

pie6k
Copy link
Collaborator

@pie6k pie6k commented May 25, 2018

Now things like

@SchemaRoot()
class FooSchema {
  private bar: number = 42;

  @Query()
  foo(): number {
    return this.bar;
  }
}

are possible.

This will allow Dependency Injection at schema root level

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #39 into master will decrease coverage by 0.27%.
The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage    87.7%   87.43%   -0.28%     
==========================================
  Files          60       61       +1     
  Lines        1074     1106      +32     
  Branches      189      194       +5     
==========================================
+ Hits          942      967      +25     
- Misses        131      138       +7     
  Partials        1        1
Impacted Files Coverage Δ
src/domains/field/compiler/resolver.ts 91.95% <100%> (+0.28%) ⬆️
src/domains/schema/rootFields.ts 92.3% <100%> (-0.29%) ⬇️
src/domains/schema/error.ts 67.56% <100%> (-7.44%) ⬇️
src/services/utils/deprecation/index.ts 100% <100%> (ø) ⬆️
src/domains/schema/index.ts 86.95% <100%> (+1.95%) ⬆️
src/domains/schema/compiler.ts 94.11% <100%> (-0.48%) ⬇️
src/domains/field/compiler/services.ts 88.88% <50%> (ø) ⬆️
src/domains/schema/services.ts 90.9% <90.9%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1400b...3b04fa8. Read the comment docs.

@pie6k pie6k merged commit 426cae5 into master May 25, 2018
@pie6k pie6k deleted the feature/root-class-instances branch May 25, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant