Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise-based navigation #36

Open
thisismexp opened this issue Dec 3, 2018 · 2 comments
Open

Promise-based navigation #36

thisismexp opened this issue Dec 3, 2018 · 2 comments

Comments

@thisismexp
Copy link

Good morning everybody,
i'am sorry for opening an issue on this; did not found an more appropriate place for it. While working on a project using mineflayer-navigate my code very fast became a mess because of all the events fired and holding status objects and so on.
After a while i started to wrap this module in a promise based manner in order to use it in a more sequential style (without loosing any of the concurrency features), and express temporary dependencies better. This weekend i decided to proper document my code and publish it.
Feel free to use it and it would be a pleasure if my code becomes part of this one (i avoided a pull request, because this topic was never discussed here, but it would be a pleasure to do so).

github: mineflayer-navigate-promise
npm: mineflayer-navigate-promise

@rom1504
Copy link
Member

rom1504 commented Dec 3, 2018 via email

@thisismexp
Copy link
Author

Thank you for your reply.
Oh, to be honest, i did not checked the mineflayer issue page on this. But yeah, as you suggest, i just extended the api by some (3) functions and all the previous introduced functions should work as before.
Just let me know your opinion on my little project when you looked at it. Since i'am new to the javascript world i do not claim that my code is flawless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants