Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplemented packetIDs for 1.5 #45

Closed
buschtoens opened this issue Mar 14, 2013 · 6 comments
Closed

Unimplemented packetIDs for 1.5 #45

buschtoens opened this issue Mar 14, 2013 · 6 comments

Comments

@buschtoens
Copy link
Contributor

With or without keepAlive: true the client randomly crashes without any errors.
The Server shows this error:

java.net.SocketException: Connection reset
        at java.net.SocketInputStream.read(SocketInputStream.java:189)
        at java.net.SocketInputStream.read(SocketInputStream.java:121)
        at java.io.FilterInputStream.read(FilterInputStream.java:133)
        at asa.a(Unknown Source)
        at asa.read(Unknown Source)
        at java.io.FilterInputStream.read(FilterInputStream.java:83)
        at ei.a(SourceFile:185)
        at ci.i(SourceFile:250)
        at ci.c(SourceFile:16)
        at cj.run(SourceFile:94)
2013-03-14 18:12:11 [INFO] username lost connection: disconnect.genericReason
@buschtoens
Copy link
Contributor Author

Okay, now I get some Unrecognized packetIds like 127, 237, 150.

@andrewrk
Copy link
Member

I can confirm this bug. There is still some work to be done to be up to date with 1.5.

@mappum
Copy link
Contributor

mappum commented Mar 14, 2013

I added everything documented in the wiki, and the vanilla client works on my server which uses this library. We can try to figure out any other new packets, or just wait for other people to do it.

@andrewrk
Copy link
Member

I plan to figure it out. I can duplicate the issue by connecting to a proxy which can dump packets. When you look at packet dumps just prior to a crash you can usually figure out why it's crashing.

@zuazo
Copy link
Contributor

zuazo commented Apr 6, 2013

These packet IDs (127, 237, 150) do not actually exist in 1.5.1. These errors are caused by incorrect parsing of other packets. I think I've fixed this bug in the #50 Pull Request.

@andrewrk
Copy link
Member

andrewrk commented Apr 6, 2013

I think it's fixed by zuazo's pull request. Re-open if it is not.

@andrewrk andrewrk closed this as completed Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants