Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types issues with getByUIDs method #246

Closed
sarunast opened this issue Jun 21, 2022 · 2 comments · Fixed by #247
Closed

Types issues with getByUIDs method #246

sarunast opened this issue Jun 21, 2022 · 2 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@sarunast
Copy link
Contributor

Versions

  • @prismicio/client: 6.6.0

Reproduction

The new type change is breaking the previous type implementation of the method getByUIDs. The issue is visble on the code sandbox: https://codesandbox.io/s/keen-tess-znklvs?file=/src/index.ts. If you move the types to createClient it works. I don't think this is expected behavior based on this PR: #238

@angeloashmore
Copy link
Member

angeloashmore commented Jun 22, 2022

Hi @sarunast, thanks for reporting this. You are correct; that was unintentional. Your example should work as expected.

I fixed the issue in PR #247, but before publishing as latest, would you mind testing it out in your project? I published the changes in an alpha version (v6.6.1-alpha.0).

You can install the latest alpha with the following command:

npm install @prismicio/client@alpha

Once it is confirmed to be working, I'll merge in the fix and publish. Thanks! 🙂

@angeloashmore
Copy link
Member

The fix has been merged and published in v6.6.1.

You can upgrade to the latest version with the following command:

npm install @prismicio/client@latest

@sarunast I confirmed the fix on my side, but please let me know if it did not fix your project. Thanks again for reporting the issue. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants