Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate type tests from ts-expect to vitest built-in framework #276

Open
lihbr opened this issue Jan 20, 2023 · 0 comments
Open

Migrate type tests from ts-expect to vitest built-in framework #276

lihbr opened this issue Jan 20, 2023 · 0 comments
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit

Comments

@lihbr
Copy link
Member

lihbr commented Jan 20, 2023

Is your feature request related to a problem? Please describe.

N/A, maintenance

Describe the solution you'd like

Vitest now provides a built-in framework to perform type testing: https://vitest.dev/guide/testing-types.html
Migrating our type tests to it could allow us to have both unit and type tests be powered by the same test framework. Vitest type testing also has a built-in way of naming type tests, making for a better DX.

Describe alternatives you've considered

Doing nothing and remaining on ts-expect is an option, although I think the better DX offered by Vitest type testing makes the move worth it. It also removes one library from our stack.

Additional context

I was pretty sure the new type testing feature of Vite was flagged as experimental, but I can't find any mention of it anymore in the doc/code, so I guess it's now considered stable.

@lihbr lihbr added enhancement New feature or request v7 Getting addressed or related to version 7 of the kit labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7 Getting addressed or related to version 7 of the kit
Projects
None yet
Development

No branches or pull requests

1 participant