Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: remove optimize parameter #290

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented May 5, 2023

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR reverts #285.

#285 was motivated by a need to cache-bust /api/v2 requests in Next.js apps using its recently-released fetch() caching behavior. This strategy ultimately did not work.

The optimize parameter should be removed now that it does not have a real-world purpose.

Note: This also removes the x-valid-until URL parameter that was added to /api/v2 in #285.

Note: This PR retains a bug fix in the concurrent requests logic from from #285.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐧

@codecov-commenter
Copy link

Codecov Report

Merging #290 (1297e7f) into v7 (343534f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##               v7     #290      +/-   ##
==========================================
+ Coverage   99.89%   99.94%   +0.05%     
==========================================
  Files          49       49              
  Lines        5805     5650     -155     
  Branches      311      299      -12     
==========================================
- Hits         5799     5647     -152     
+ Misses          6        3       -3     
Impacted Files Coverage Δ
src/createClient.ts 100.00% <100.00%> (+0.15%) ⬆️

@angeloashmore angeloashmore marked this pull request as ready for review May 6, 2023 05:06
@angeloashmore angeloashmore added the v7 Getting addressed or related to version 7 of the kit label May 6, 2023
@angeloashmore angeloashmore requested a review from lihbr May 6, 2023 05:07
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angeloashmore angeloashmore merged commit f1e6f9a into v7 May 9, 2023
12 checks passed
@angeloashmore angeloashmore deleted the aa/v7-remove-optimize-param branch May 9, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v7 Getting addressed or related to version 7 of the kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants