fix: support partial document in asLink()
and documentToLinkField()
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR fixes a bug where
asLink()
would throw an error when given a Prismic document without adata
property.The following error is thrown (the stacktrace has been truncated):
This happens because
documentToLinkField()
tries to callObject.keys()
ondocument.data
, which isundefined
.Although
asLink()
(and its underlyingdocumentToLinkField()
) is typed to only accept full Prismic documents, a partial document could be passed in untyped projects.Context
The issue this PR solves was discovered while resolving this
@prismicio/react
issue: prismicio/prismic-react#150Checklist:
🐳