fix: support union with image thumbnails, fixes #27 #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Union with image thumbnails were not handled correctly with TypeScript. This PR fixes it by refactoring the type, extending the root image object with thumbnails, and wrapping it with
Omit<>
to prevent TypeScript from considering the refactored type as an array (found by @angeloashmore).Just created a PR to make sure we're aligned on it before moving forward with this "hacky" method. The goal of
@prismicio/types
being to provide types as close and precise as possible to what Prismic API responses can be.Resolves: #27
Checklist: