Skip to content

Commit

Permalink
fix(dom): asDate using wrong return value
Browse files Browse the repository at this point in the history
  • Loading branch information
lihbr committed Apr 8, 2021
1 parent 0956f8b commit 6df2abe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/sdk/DOM.ts
Expand Up @@ -2,9 +2,9 @@ import PrismicDOM from "prismic-dom";
import type {
PrismicPluginOptions,
LinkResolver,
RichTextBlock,
HtmlSerializer,
LinkField
LinkField,
RichTextField
} from "../types";
import { SDK, SDKWithInterface, SDKWithInterfaceKeys } from "./SDK";

Expand All @@ -24,12 +24,12 @@ export class DOM extends SDK implements SDKWithInterface<DOMInterface> {
};
}

asText = (richText: RichTextBlock[] = [], joinString?: string): string => {
asText = (richText: RichTextField, joinString?: string): string => {
return PrismicDOM.RichText.asText(richText, joinString);
};

asHtml = (
richText: RichTextBlock[] = [],
richText: RichTextField,
linkResolver?: LinkResolver,
htmlSerializer?: HtmlSerializer<string>
): string => {
Expand All @@ -47,8 +47,8 @@ export class DOM extends SDK implements SDKWithInterface<DOMInterface> {
return PrismicDOM.Link.url(link, linkResolver);
};

asDate = (date?: string): string => {
asDate = (date?: string): Date | undefined => {
// PrismicDOM.Date() can return null
return PrismicDOM.Date(date) || "";
return PrismicDOM.Date(date) || undefined;
};
}
2 changes: 1 addition & 1 deletion src/sdk/prismic-dom.d.ts
Expand Up @@ -8,7 +8,7 @@ declare module "prismic-dom" {
url: (link?: any, linkResolver?: LinkResolver) => string;
};

function Date(date?: string): string | null;
function Date(date?: string): Date | null;

interface Elements {
heading1: "heading1";
Expand Down

0 comments on commit 6df2abe

Please sign in to comment.