More graceful stack overflow handling #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #77, if a stack overflow occurs in one of the computations threads (e.g., SCC analysis in a "deep" model, very heavily nested formulas/expressions, ...), the GUI does not notice that the computation thread is gone as the error handling there only catches Exceptions and not Errors. Errors are generally serious and should not be caught, but for a StackOverflowError we can gracefully recover by just ending the computation thread, the same as for other exceptions.
This PR addresses:
Have not tested on Linux / Windows yet, but don't expect trouble...
For the GUI, I think I covered the most likely situations (steady-state computation, verification, experiments) in testing. The test case for #77 is good for triggering the overflow in the explicit engine, either for steady-state computation or using a
S=?[ ... ]
property.