Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a union type for types defined as array #141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rodrigo-arias
Copy link
Contributor

@rodrigo-arias rodrigo-arias commented Mar 21, 2022

@pristas-peter for the templateLock attribute the type is declared as an array instead of a string. This code creates a union and avoids the warning.

Closes #127

CleanShot 2022-03-21 at 16 08 14

CleanShot 2022-03-21 at 16 06 09

Let me know if it makes sense to you. I tried to follow the code standard of the file although it does not match WordPress-Core. Thanks

@rodrigo-arias
Copy link
Contributor Author

Nevermind, seems that GraphQL doesn't support union on scalar types. Maybe you can give me an idea how to solve this

@pressoholics
Copy link

Hi @pristas-peter We have confirmed that this fix works for us.

Related to this issue:
#158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not determine type of attribute "templateLock"
2 participants