Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msm bench #174

Closed
wants to merge 1 commit into from
Closed

Add msm bench #174

wants to merge 1 commit into from

Conversation

SuccinctPaul
Copy link

No description provided.

@CPerezz
Copy link
Member

CPerezz commented May 2, 2023

I'm not sure I follow why do we need the MSM bench specifically here. Could you elaborate @ChengYueJia ??

@SuccinctPaul
Copy link
Author

SuccinctPaul commented May 14, 2023 •
edited

I'm not sure I follow why do we need the MSM bench specifically here. Could you elaborate @ChengYueJia ??

It can be easier to compare the msm performance on cpu and the one on gpu.

@CPerezz
Copy link
Member

CPerezz commented May 15, 2023

I think this should rather be inside the curve implementation crates rather than in the Halo2 repo.

@SuccinctPaul
Copy link
Author

I think this should rather be inside the curve implementation crates rather than in the Halo2 repo.

Sound good! I'll submit a new pr in halo2curves.

@SuccinctPaul SuccinctPaul mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuccinctPaul @CPerezz