Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile rule for publishing doesn't work #61

Closed
CPerezz opened this issue Jul 4, 2023 · 2 comments · Fixed by #64
Closed

Makefile rule for publishing doesn't work #61

CPerezz opened this issue Jul 4, 2023 · 2 comments · Fixed by #64
Assignees
Labels
T-bug Type: bug

Comments

@CPerezz
Copy link
Member

CPerezz commented Jul 4, 2023

The Makefile fails to publish with:

Enter passphrase for key '......': 
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:privacy-scaling-explorations/halo2curves.git
 * [new tag]         v0.1.0 -> v0.1.0
cargo release publish --execute  --verbose
error: no such subcommand: `release`
make: *** [Makefile:16: release] Error 101

Idk why we have the release there. But is definitely wrong.
Will do a PR ASAP. In any case, the thing is already in crates.io.

Originally posted by @CPerezz in #60 (comment)

@CPerezz CPerezz added the T-bug Type: bug label Jul 4, 2023
@CPerezz CPerezz self-assigned this Jul 4, 2023
@huitseeker
Copy link
Contributor

The tool used for the publication of the crate is cargo-release, which you can install from there:
https://github.com/crate-ci/cargo-release
So in the Makefile, when you read "cargo release publish" is means "use the publish subcommand of the cargo-release tool". See ref here:
https://github.com/crate-ci/cargo-release/blob/master/docs/reference.md

Unfortunately, the cargo-release utility must be installed on the operator's machine (i.e.the person who runs the Makefile)

As cargo-release is used to prepare the release, this allows a few nice perks such as configuration-based setup of features passed to cargo-publish, etc.

Please also note the TODOs of the release PR, which are still active (notably the tags):
#59

@CPerezz
Copy link
Member Author

CPerezz commented Jul 7, 2023

Wasn't aware of the existance of such cargo ext.
Will publish the tag and start using this from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
2 participants