Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Create workflow and configuration for a release #59

Merged

Conversation

huitseeker
Copy link
Contributor

@huitseeker huitseeker commented Jun 27, 2023

This uses:

This is hopefully the first step towards a release process, to which we could add the fancy things we'd want in the future (e.g. GitHub artifacts, changelog management, semver-checks ...). The workflow above, some might recognize, is the one currently run by arkworks (modulo a couple of improvements from me in places).

TODO:

  1. allow workflows to open PRs before you run this (on workflow-dispatch): https://user-images.githubusercontent.com/155787/233333834-4dbe7127-3b6c-4d47-b48a-8a7fdd0b23ce.png
  2. delete the version tags inherited by the fact this repo is a fork, and that are NOT relevant to halo2curves, as they would be clobbered by the release tooling:
huitseeker@lightning.local➜~/tmp/halo2curves(main)» git tags                                                                                                                                                                         [16:05:54]
0.2.1
0.3.0
0.3.1
0.3.2
0.3.3
v0.2.0

For reference, the version number was rolled back to 0.1.0 (stg more relevant to this work) here.

@CPerezz CPerezz self-requested a review June 28, 2023 08:04
samuelburnham added a commit to samuelburnham/neptune that referenced this pull request Jun 29, 2023
- Introduced a new GitHub release PR template, complete with manual instructions for publishing the cargo crate and version comparison checks.
- Added 'get_current_version.sh', a new script for fetching the current version of the crate
- Installed 'cargo-release' and integrated 'cargo-bins/release-pr' for creating the PR.
- Included a condition to compare input and current version, thus preventing unnecessary workflow runs for non-updated versions.
- Introduced a new `release.toml` file that disallows commit consolidation.
- Implemented a new makefile containing `doc` and `release` commands.
Copy link
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All scripts ran and checked locally (except Makefile but it also LGTM). Thanks a lot for helping adding this!

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks a lot for adding all this machinery to automate the releases!!

Now it's time for @han0110 @davidnevadoc @kilic and I to generate a crates.io token to share and try this!
LGTM!

One minor thing, is that there are two files that lack the new line at the end. But it;'s just a detail. So feel free to omit.

@CPerezz CPerezz added this pull request to the merge queue Jul 3, 2023
Merged via the queue into privacy-scaling-explorations:main with commit 9a7f726 Jul 3, 2023
7 checks passed
github-merge-queue bot pushed a commit to lurk-lab/neptune that referenced this pull request Jul 3, 2023
* Add release-pr action

* Update taiki-e/install-action

* Add version check and polish

Copied from privacy-scaling-explorations/halo2curves#59

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants