-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Create workflow and configuration for a release #59
ci: Create workflow and configuration for a release #59
Conversation
- Introduced a new GitHub release PR template, complete with manual instructions for publishing the cargo crate and version comparison checks. - Added 'get_current_version.sh', a new script for fetching the current version of the crate - Installed 'cargo-release' and integrated 'cargo-bins/release-pr' for creating the PR. - Included a condition to compare input and current version, thus preventing unnecessary workflow runs for non-updated versions.
933a21f
to
10c298b
Compare
- Introduced a new `release.toml` file that disallows commit consolidation. - Implemented a new makefile containing `doc` and `release` commands.
10c298b
to
b2fd03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All scripts ran and checked locally (except Makefile
but it also LGTM). Thanks a lot for helping adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks a lot for adding all this machinery to automate the releases!!
Now it's time for @han0110 @davidnevadoc @kilic and I to generate a crates.io token to share and try this!
LGTM!
One minor thing, is that there are two files that lack the new line at the end. But it;'s just a detail. So feel free to omit.
9a7f726
* Add release-pr action * Update taiki-e/install-action * Add version check and polish Copied from privacy-scaling-explorations/halo2curves#59 * Fix typo
This uses:
Makefile
by anyone equipped with the correct crates.io token,This is hopefully the first step towards a release process, to which we could add the fancy things we'd want in the future (e.g. GitHub artifacts, changelog management, semver-checks ...). The workflow above, some might recognize, is the one currently run by arkworks (modulo a couple of improvements from me in places).
TODO:
For reference, the version number was rolled back to 0.1.0 (stg more relevant to this work) here.