Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New crate release #96

Closed
huitseeker opened this issue Oct 23, 2023 · 3 comments
Closed

New crate release #96

huitseeker opened this issue Oct 23, 2023 · 3 comments

Comments

@huitseeker
Copy link
Contributor

huitseeker commented Oct 23, 2023

The repo has recently landed awesome PRs such as #83, as well as PRs such as #85 and #88 that change core data formats. Once #95 lands, it would be great to have a new release of the halo2curves crate, for consumption in projects such as Nova.

@mratsim
Copy link
Contributor

mratsim commented Oct 23, 2023

Note, for #95, at the current state it will be exposing jacobi, legendre and the Legendre trait.

I don't think I've heard any direction regarding where to go with the API

  1. AFAIK it was because exponentiation by (p-1)/2 needed to abstract away the usage of curve-specific modulus constants.
    In that case, the trait can be deleted, it should be recent enough that breakage is minimal if any (cc @huitseeker).
  2. Alternatively, the legendre procedure can call jacobi instead and the Legendre trait can be preserved. Though I'm curious what's the use-case of a trait instead of a function in that case.

I'm personally in-favor of removing the Legendre trait.

Another change of note is #86, we need to remove the MSM/FFT impl from halo2 repo when upgrading it to avoid ambiguous calls.

@CPerezz
Copy link
Member

CPerezz commented Oct 31, 2023

Would be nice to have some sort of solution for zkcrypto/group#48 prior to releasing. But we can release a patch on the meantime if needed.

Agree then we need to address the comments of @mratsim.

@mratsim
Copy link
Contributor

mratsim commented Dec 18, 2023

closed by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants