Anonymous Components for Sha256 hashers #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjei
requested review from
ctrlc03,
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
8 tasks
ctrlc03
merged commit 2d647e7
into
privacy-scaling-explorations:refactor/circom-circuits
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to remove Sha256Hashers variant templates (e.g., Sha256Hasher4) by instantiating the
Sha256Hasher()template directly in the code. This reduces the number of lines of code and makes it easier to read.Additional Notes
PoseidonHashtemplate has been renamedPoseidonHasherto follow the other hashers template name convention.PoseidonHasher,Sha256HasherandMessageHasher) have been grouped under thehashers.circomfile.Related issue(s)
See privacy-scaling-explorations/zk-kit#131
Confirmation