fix(circuits): valid message censoring #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad,
samajammin and
crisgarner
as code owners
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
changed the title
0xmad
approved these changes
Feb 16, 2024
0xmad
force-pushed
the
fix/second-valid-message-censoring
branch
from
253f952
to
9a17cd0
Compare
|
LGTM! With regards to the todo comment, I believe we do still need that check in there because the transformer output is used to set the new SlPublicKeys - https://github.com/privacy-scaling-explorations/maci/blob/dev/circuits/circom/processMessages.circom#L651-L652 You could use the new voteOption check in processOne and then set the public keys based off that. Up to you though. |
ctrlc03
force-pushed
the
fix/second-valid-message-censoring
branch
from
9a17cd0
to
8c56d25
Compare
…currentVoteWeight Prevent coordinator censoring a valid second message by passing the currentVoteWeight equal to a value which would result in not enough voice credits in the circuit
ctrlc03
force-pushed
the
fix/second-valid-message-censoring
branch
from
8c56d25
to
d747b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent a coordinator from censoring the second valid vote of an user by setting currentVoteWeight to 0.
With this fix, they are forced to send the previous vote weight for the option index of the current processed message, otherwise the inclusion proof will fail to validate due to merkle root mismatch
Confirmation