Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add publish batch method for cli sdk #1251

Merged
merged 1 commit into from Feb 27, 2024
Merged

feat(cli): add publish batch method for cli sdk #1251

merged 1 commit into from Feb 27, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Feb 26, 2024

Description

Add publish batch method for maci-cli sdk.

Additional Notes

N/A

Related issue(s)

Related to privacy-scaling-explorations/maci-rpgf#7

Confirmation

@0xmad 0xmad added the enhancement New feature or request label Feb 26, 2024
@0xmad 0xmad self-assigned this Feb 26, 2024
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 843fe7e
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65ddf87e23dfa60008650427
😎 Deploy Preview https://deploy-preview-1251--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add publish test cmd in package.json?

cli/ts/utils/interfaces.ts Show resolved Hide resolved
@0xmad
Copy link
Collaborator Author

0xmad commented Feb 27, 2024

maybe also add publish test cmd in package.json?

Unit tests can be run via test:unit command.

@0xmad 0xmad requested a review from kittybest February 27, 2024 14:57
@kittybest
Copy link
Collaborator

maybe also add publish test cmd in package.json?

Unit tests can be run via test:unit command.

I mean something like test:publish? since I saw there are commands for other single unit test

@0xmad
Copy link
Collaborator Author

0xmad commented Feb 27, 2024

maybe also add publish test cmd in package.json?

Unit tests can be run via test:unit command.

I mean something like test:publish? since I saw there are commands for other single unit test

Ok, why do you need it? If I run tests for cli, I just run all the tests to make sure if nothing is broken.

@kittybest
Copy link
Collaborator

maybe also add publish test cmd in package.json?

Unit tests can be run via test:unit command.

I mean something like test:publish? since I saw there are commands for other single unit test

Ok, why do you need it? If I run tests for cli, I just run all the tests to make sure if nothing is broken.

ok, then never mind.

@0xmad 0xmad merged commit 8b9a018 into dev Feb 27, 2024
19 checks passed
@0xmad 0xmad deleted the feature/voting branch February 27, 2024 15:22
BigInt(coordinatorPubKeyResult.y.toString()),
]);

const encryptionKeypair = new Keypair();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point of using the same key here for all messages in the batch, we just assume that all messages in the batch are from the same user either way for simplicity sake (though that doesn't necessarily have to be the case), so I would suggest we move line 226 out of the loop to avoid computing the ECDH key every time; and also we should probably return this key like we do in publishMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants