Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export pubkey and update description of deployment #1475

Merged
merged 1 commit into from
May 16, 2024
Merged

feat: export pubkey and update description of deployment #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/ts/sdk/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export {

export * from "maci-contracts/typechain-types";

export { VerifyingKey, type IVkObjectParams } from "maci-domainobjs";
export { VerifyingKey, PubKey, type IVkObjectParams } from "maci-domainobjs";

export type {
TallyData,
Expand Down
13 changes: 6 additions & 7 deletions contracts/tasks/helpers/Deployment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import type { ConfigurableTaskDefinition, HardhatRuntimeEnvironment, TaskArgumen
import { ContractStorage } from "./ContractStorage";
import {
EContracts,
IDeployContractArgs,
IDeployContractWithLinkedLibrariesArgs,
IDeployContractParams,
IDeployContractWithLinkedLibrariesParams,
IDeployParams,
IDeployStep,
IDeployStepCatalog,
Expand Down Expand Up @@ -309,13 +309,12 @@ export class Deployment {
/**
* Deploy contract and return it
*
* @param contractName - contract name
* @param signer - signer
* @param {IDeployContractParams} params - parameters of deploy contract
* @param args - constructor arguments
* @returns deployed contract
*/
async deployContract<T extends BaseContract>(
{ name, abi, bytecode, signer }: IDeployContractArgs,
{ name, abi, bytecode, signer }: IDeployContractParams,
...args: unknown[]
): Promise<T> {
const deployer = signer || (await this.getDeployer());
Expand All @@ -337,12 +336,12 @@ export class Deployment {
/**
* Deploy contract with linked libraries using contract factory
*
* @param contractFactory - ethers contract factory
* @param {IDeployContractWithLinkedLibrariesParams} params - parameters of deploy contract with linked libraries
* @param args - constructor arguments
* @returns deployed contract
*/
async deployContractWithLinkedLibraries<T extends BaseContract>(
{ contractFactory, signer }: IDeployContractWithLinkedLibrariesArgs,
{ contractFactory, signer }: IDeployContractWithLinkedLibrariesParams,
...args: unknown[]
): Promise<T> {
const deployer = signer || (await this.getDeployer());
Expand Down
4 changes: 2 additions & 2 deletions contracts/tasks/helpers/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ export type TAbi = string | readonly (string | Fragment | JsonFragment)[];
/**
* Interface that represents deploy params
*/
export interface IDeployContractArgs {
export interface IDeployContractParams {
/**
* Contract name
*/
Expand All @@ -676,7 +676,7 @@ export interface IDeployContractArgs {
/**
* Interface that represents deploy params
*/
export interface IDeployContractWithLinkedLibrariesArgs {
export interface IDeployContractWithLinkedLibrariesParams {
/**
* Contract factory
*/
Expand Down
Loading