Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zkeys): use ts to download zkey artifacts and simplify repo #1505

Merged
merged 1 commit into from
May 28, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented May 23, 2024

Description

Use maci-coordinator ts script to download zkeys.

Confirmation

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 28, 2024 1:48pm

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one question/suggestion

coordinator/package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad
Copy link
Collaborator

0xmad commented May 23, 2024

@ctrlc03 I think here can be a conflict with deployment PR https://github.com/privacy-scaling-explorations/maci/pull/1504/files#diff-a525b6eda189da3c0d33cef4ba01ba60f29225586df01dab199b486f701e812aR28-R30
So, can we merge it or wait for your PR?

Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad enabled auto-merge May 28, 2024 13:43
@0xmad 0xmad merged commit 3a1316e into dev May 28, 2024
21 checks passed
@0xmad 0xmad deleted the chore/zkeys-download branch May 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants