-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IO wrapper for OLE #138
Conversation
94d01f4
to
5215d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So clean 👌
Couple requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥
Just 1 nit on needing newtypes for the ideal impl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gw!
commit 2f35271 Author: sinu.eth <65924192+sinui0@users.noreply.github.com> Date: Fri May 31 06:36:31 2024 -0700 feat(mpz-common): scoped! macro (#143) commit 9b51bd4 Author: sinu.eth <65924192+sinui0@users.noreply.github.com> Date: Fri May 31 06:35:16 2024 -0700 feat(mpz-common): Context::blocking (#141) * feat(mpz-common): Context::blocking * Apply suggestions from code review Co-authored-by: dan <themighty1@users.noreply.github.com> --------- Co-authored-by: dan <themighty1@users.noreply.github.com> commit 8f0b298 Author: th4s <th4s@metavoid.xyz> Date: Fri May 31 10:30:08 2024 +0200 Add IO wrapper for OLE (#138) * Add `mpz-ole` content of old branch. * Reworked message enum. * Refactored to work with new `mpz-ole-core`. * Add part of feedback. * Add more feedback. * Add opaque error type. * Add `Display` for `OLEErrorKind` * Use `ok_or_elese` for lazy heap alloc. * Adapted `mpz-ole` to `hybrid-array`. * WIP: Improving API of const generics... * Add random OT for `hybrid-array`. * Adapt `mpz-ole` to use new random OT. * Added feedback. * Use random OT over field elements instead of arrays. * Refactored ideal implementation to use `mpz-common`. * Added more feedback.
* Add `mpz-ole` content of old branch. * Reworked message enum. * Refactored to work with new `mpz-ole-core`. * Add part of feedback. * Add more feedback. * Add opaque error type. * Add `Display` for `OLEErrorKind` * Use `ok_or_elese` for lazy heap alloc. * Adapted `mpz-ole` to `hybrid-array`. * WIP: Improving API of const generics... * Add random OT for `hybrid-array`. * Adapt `mpz-ole` to use new random OT. * Added feedback. * Use random OT over field elements instead of arrays. * Refactored ideal implementation to use `mpz-common`. * Added more feedback.
* Add `mpz-ole` content of old branch. * Reworked message enum. * Refactored to work with new `mpz-ole-core`. * Add part of feedback. * Add more feedback. * Add opaque error type. * Add `Display` for `OLEErrorKind` * Use `ok_or_elese` for lazy heap alloc. * Adapted `mpz-ole` to `hybrid-array`. * WIP: Improving API of const generics... * Add random OT for `hybrid-array`. * Adapt `mpz-ole` to use new random OT. * Added feedback. * Use random OT over field elements instead of arrays. * Refactored ideal implementation to use `mpz-common`. * Added more feedback.
This PR adds the async wrapper crate for OLE.