Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IO wrapper for OLE #138

Merged
merged 16 commits into from
May 31, 2024
Merged

Add IO wrapper for OLE #138

merged 16 commits into from
May 31, 2024

Conversation

th4s
Copy link
Member

@th4s th4s commented May 20, 2024

This PR adds the async wrapper crate for OLE.

@th4s th4s requested review from sinui0 and themighty1 May 20, 2024 13:48
crates/mpz-ole/src/msg.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
@th4s th4s requested a review from sinui0 May 21, 2024 10:53
@th4s th4s force-pushed the add-mpz-ole branch 2 times, most recently from 94d01f4 to 5215d1b Compare May 27, 2024 14:14
Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean 👌

Couple requests

crates/mpz-ole/src/ideal.rs Show resolved Hide resolved
crates/mpz-ole/src/ideal.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/receiver.rs Outdated Show resolved Hide resolved
crates/mpz-ole/src/rot/sender.rs Outdated Show resolved Hide resolved
Base automatically changed from add-mpz-ole-core to threading-refactor May 29, 2024 09:02
@th4s th4s requested a review from sinui0 May 29, 2024 12:07
Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Just 1 nit on needing newtypes for the ideal impl.

crates/mpz-ole/src/ideal.rs Show resolved Hide resolved
crates/mpz-ole/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw!

@th4s th4s merged commit 8f0b298 into threading-refactor May 31, 2024
@th4s th4s deleted the add-mpz-ole branch May 31, 2024 08:30
sinui0 added a commit that referenced this pull request May 31, 2024
commit 2f35271
Author: sinu.eth <65924192+sinui0@users.noreply.github.com>
Date:   Fri May 31 06:36:31 2024 -0700

    feat(mpz-common): scoped! macro (#143)

commit 9b51bd4
Author: sinu.eth <65924192+sinui0@users.noreply.github.com>
Date:   Fri May 31 06:35:16 2024 -0700

    feat(mpz-common): Context::blocking (#141)

    * feat(mpz-common): Context::blocking

    * Apply suggestions from code review

    Co-authored-by: dan <themighty1@users.noreply.github.com>

    ---------

    Co-authored-by: dan <themighty1@users.noreply.github.com>

commit 8f0b298
Author: th4s <th4s@metavoid.xyz>
Date:   Fri May 31 10:30:08 2024 +0200

    Add IO wrapper for OLE (#138)

    * Add `mpz-ole` content of old branch.

    * Reworked message enum.

    * Refactored to work with new `mpz-ole-core`.

    * Add part of feedback.

    * Add more feedback.

    * Add opaque error type.

    * Add `Display` for `OLEErrorKind`

    * Use `ok_or_elese` for lazy heap alloc.

    * Adapted `mpz-ole` to `hybrid-array`.

    * WIP: Improving API of const generics...

    * Add random OT for `hybrid-array`.

    * Adapt `mpz-ole` to use new random OT.

    * Added feedback.

    * Use random OT over field elements instead of arrays.

    * Refactored ideal implementation to use `mpz-common`.

    * Added more feedback.
sinui0 pushed a commit that referenced this pull request Jun 25, 2024
* Add `mpz-ole` content of old branch.

* Reworked message enum.

* Refactored to work with new `mpz-ole-core`.

* Add part of feedback.

* Add more feedback.

* Add opaque error type.

* Add `Display` for `OLEErrorKind`

* Use `ok_or_elese` for lazy heap alloc.

* Adapted `mpz-ole` to `hybrid-array`.

* WIP: Improving API of const generics...

* Add random OT for `hybrid-array`.

* Adapt `mpz-ole` to use new random OT.

* Added feedback.

* Use random OT over field elements instead of arrays.

* Refactored ideal implementation to use `mpz-common`.

* Added more feedback.
sinui0 pushed a commit that referenced this pull request Jun 25, 2024
* Add `mpz-ole` content of old branch.

* Reworked message enum.

* Refactored to work with new `mpz-ole-core`.

* Add part of feedback.

* Add more feedback.

* Add opaque error type.

* Add `Display` for `OLEErrorKind`

* Use `ok_or_elese` for lazy heap alloc.

* Adapted `mpz-ole` to `hybrid-array`.

* WIP: Improving API of const generics...

* Add random OT for `hybrid-array`.

* Adapt `mpz-ole` to use new random OT.

* Added feedback.

* Use random OT over field elements instead of arrays.

* Refactored ideal implementation to use `mpz-common`.

* Added more feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants