Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Korean #121

Closed
ChialiT opened this issue Jan 25, 2024 · 5 comments
Closed

Translation: Korean #121

ChialiT opened this issue Jan 25, 2024 · 5 comments

Comments

@ChialiT
Copy link
Member

ChialiT commented Jan 25, 2024

Open for translation on the following page:

  • Home page
  • Project lib
  • Resource
  • About

How:
Navigate to https://github.com/privacy-scaling-explorations/website-v2/tree/main/app/i18n/locales
Duplicate the "en" folder for translation.

I hope this will be a group collaboration effort; if you have any questions, please leave comments.

@2ssunny
Copy link
Contributor

2ssunny commented Mar 5, 2024

Hi I want to contributing Translating your page to Korean. I want to ask you into which branch from my forked repository to make PR. Do I just make PR to main branch?

@ChialiT
Copy link
Member Author

ChialiT commented Mar 5, 2024

Hi I want to contributing Translating your page to Korean. I want to ask you into which branch from my forked repository to make PR. Do I just make PR to main branch?

Thank you so much @2ssunny

You could just fork the main branch and submit PR to main branch too, there will be review, approval needed before merge.

@2ssunny
Copy link
Contributor

2ssunny commented Mar 5, 2024

Okay I understood. I will submit PR to main branch after translating in Korean

@2ssunny
Copy link
Contributor

2ssunny commented Mar 5, 2024

Check PR #148 please. If you comment what to edit, I will edit and push again.

@kalidiagne
Copy link
Collaborator

Closing this issue as it has now been merged. Thank you, @2ssunny @wanseob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants