Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation in Japanese #163

Merged
merged 91 commits into from
Jun 20, 2024
Merged

Translation in Japanese #163

merged 91 commits into from
Jun 20, 2024

Conversation

zukizukizuki
Copy link
Contributor

@zukizukizuki zukizukizuki commented Apr 12, 2024 •
edited
Loading

Japanese translation was performed.

Things did

  • Copy en folder
  • Translated values in Json from English to Japanese

Notes

English that can be understood in Japan is left as it is.

Issue

#122

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024

@zukizukizuki is attempting to deploy a commit to the Privacy and Scaling Explorations Team on Vercel.

A member of the Team first needs to authorize it.

@zukizukizuki zukizukizuki changed the title first create Translation in Japanese Apr 12, 2024
@zukizukizuki
Copy link
Contributor Author

@ChialiT
please check it.

@ChialiT ChialiT self-requested a review April 12, 2024 17:05
@zukizukizuki
Copy link
Contributor Author

@ChialiT
How's it going?

@ChialiT
Copy link
Member

ChialiT commented Apr 17, 2024

@ChialiT How's it going?

Thank you for pinging me, I asked one of our member to review the translation. my Japanese is very limited.

@tkmct
Copy link
Contributor

tkmct commented Apr 22, 2024

Hi @zukizukizuki, thank you for your contribution. I'm currently reviewing your translation. Bear with me for a moment please.

tkmct
tkmct suggested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tkmct tkmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. I added suggestions in the PR.
Please take a look and accept those suggestions. If you need any help, let us know.

app/i18n/locales/jp/common.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/about-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/about-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/about-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/resources-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/projects-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/projects-page.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/what-we-do-section.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/what-we-do-section.json Outdated Show resolved Hide resolved
app/i18n/locales/jp/what-we-do-section.json Outdated Show resolved Hide resolved
zukizukizuki and others added 19 commits April 22, 2024 22:06
@zukizukizuki @tkmct
Update app/i18n/locales/jp/common.json
1ad6613 
Yes sir, COMMIT.

Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
4020b55 
Yes sir, COMMIT.

Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
412195e 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
10956df 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/resources-page.json
64f879d 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/resources-page.json
da598c1 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
25ff0c9 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
920246a 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
e73ed35 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
2d6aeb7 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
99d6268 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
abfa291 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
f2524e7 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
dea5f93 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
715ecc3 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
67c395d 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
5429a28 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
91943be 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/news-section.json
a7a199b 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
zukizukizuki and others added 17 commits April 22, 2024 22:24
@zukizukizuki @tkmct
Update app/i18n/locales/jp/homepage.json
cf35415 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/homepage.json
2daafad 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/homepage.json
759b79f 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
f936272 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
9d8eec0 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
f8f6054 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
232319a 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
e66dc6d 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
5ac46f2 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
f9e6498 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
63edf0e 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
da091d2 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
57082ac 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
88e1ced 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
ead6b2b 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
2fb2b92 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki @tkmct
Update app/i18n/locales/jp/programs-page.json
3dc1c64 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
@zukizukizuki
Copy link
Contributor Author

@tkmct
thank you for your review!
All imported.

tkmct
tkmct suggested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tkmct tkmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I missed one change. Can you apply the suggested change too?

app/i18n/locales/jp/about-page.json Outdated Show resolved Hide resolved
@zukizukizuki @tkmct
Update app/i18n/locales/jp/about-page.json
ec339ed 
Co-authored-by: tkmct <1220t.takamichi@gmail.com>
tkmct
tkmct approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tkmct tkmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@zukizukizuki zukizukizuki requested a review from tkmct April 22, 2024 14:05
@zukizukizuki
Copy link
Contributor Author

@tkmct (@ChialiT)
thank you!Waiting for approval.

@AtHeartEngineer
Copy link
Member

@tkmct Do you think this is ready to merge?

@ChialiT
Copy link
Member

ChialiT commented Jun 19, 2024

@AtHeartEngineer can u approve this one so i can merge it?thanks

@AtHeartEngineer AtHeartEngineer requested review from AtHeartEngineer and removed request for tkmct June 19, 2024 12:48
@ChialiT ChialiT merged commit ef5efe3 into privacy-scaling-explorations:main Jun 20, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtHeartEngineer AtHeartEngineer AtHeartEngineer approved these changes

@tkmct tkmct tkmct approved these changes

@ChialiT ChialiT ChialiT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zukizukizuki @ChialiT @tkmct @AtHeartEngineer