Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in Korean #148

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

2ssunny
Copy link

@2ssunny 2ssunny commented Mar 5, 2024

I translated Home page, Project lib, Resource, About pages in Korean (Issue #121 )
The translation may be unnatural. I will check and correct it as soon as I find it.

Copy link

vercel bot commented Mar 5, 2024

@2ssunny is attempting to deploy a commit to the Privacy and Scaling Explorations Team on Vercel.

A member of the Team first needs to authorize it.

@2ssunny 2ssunny mentioned this pull request Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 6:47pm
website-v2-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 6:47pm

@2ssunny
Copy link
Author

2ssunny commented Mar 6, 2024

I found a typo, and fixed it. 😅

@kalidiagne
Copy link
Collaborator

I found a typo, and fixed it. 😅

Thank you @2ssunny!

You can also double from preview here: https://website-v2-git-fork-2ss-4cc270-privacy-and-scaling-explorations.vercel.app/ko

app/i18n/locales/ko/about-page.json Outdated Show resolved Hide resolved
app/i18n/locales/ko/about-page.json Outdated Show resolved Hide resolved
app/i18n/locales/ko/about-page.json Outdated Show resolved Hide resolved
Copy link
Member

@jeong0982 jeong0982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave a simple suggestion for an unnatural expression

app/i18n/locales/ko/about-page.json Outdated Show resolved Hide resolved
Co-authored-by: Soowon Jeong <soowon1106@gmail.com>
@2ssunny
Copy link
Author

2ssunny commented Mar 13, 2024

I think your suggestion gives much better translating. I applied your suggestion.

@AtHeartEngineer
Copy link
Member

@wanseob Do you think this is good?

Copy link
Member

@wanseob wanseob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say "암호" instead of "암호화" but would love to merge this PR first and then have an additional PR for the 2nd version.

We all appreciate ur contribution a lot @2ssunny

@2ssunny
Copy link
Author

2ssunny commented Jun 13, 2024

I am happy that I could help you guy! I hope my contribution could help you guys a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants