Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a package for Circom circuits #73

Closed
10 tasks done
cedoor opened this issue Nov 22, 2023 · 4 comments · Fixed by #76
Closed
10 tasks done

Create a package for Circom circuits #73

cedoor opened this issue Nov 22, 2023 · 4 comments · Fixed by #76
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new

Comments

@cedoor
Copy link
Member

cedoor commented Nov 22, 2023

Tasks:

  • Create @zk-kit/circuits package
  • Create merkle-root.circom
  • Create poseidon-proof.circom
  • Support multiple zk languages (currently Noir and Circom)
  • Document packages
  • Add tests
    • Set env
    • MT tests
    • Poseidon-proof tests
  • Add more info to readme file
@cedoor cedoor self-assigned this Nov 22, 2023
@cedoor cedoor added the feature 🚀 This is enhancing something existing or creating something new label Nov 22, 2023
@fabianschu
Copy link
Contributor

Hey @cedoor, how do you feel about adding Noir circuits as well? I've been working on a Noir implementation of your SMT implementation and was wondering if this repo might be a good place for it to live on.

@cedoor
Copy link
Member Author

cedoor commented Nov 28, 2023

Hey @cedoor, how do you feel about adding Noir circuits as well? I've been working on a Noir implementation of your SMT implementation and was wondering if this repo might be a good place for it to live on.

Hey @fabianschu, I think that would be great! We could create 1 folder for each language: packages/circuits/circom, packages/circuits/noir. How does it sound?

@fabianschu
Copy link
Contributor

Sounds great to me. I would create an issue and a PR when I've finished the circuits. Would that make sense?

cedoor added a commit that referenced this issue Nov 28, 2023
@cedoor
Copy link
Member Author

cedoor commented Nov 28, 2023

Sounds great to me. I would create an issue and a PR when I've finished the circuits. Would that make sense?

Yes, it makes sense. If the feat/circuits hasn't been merged into main yet, you can directly merge your PR into it 👍🏽

I've just pushed a commit for supporting multiple languages. You can take a look at the structure here: https://github.com/privacy-scaling-explorations/zk-kit/tree/feat/circuits/packages/circuits.

I don't know Noir but it could be nice to have some scripts for compiling Noir circuits too, like:

"circom:compile": "circomkit compile",
"circom:setup": "circomkit setup"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
Status: ✔️ Done
2 participants