-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NUMBER_OF_INPUTS
to poseidon-proof
#124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, just a few corrections in the comments!
Converted to draft to make changes to |
3fb03c8
to
4159bf5
Compare
Ready for review @cedoor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @0xjei! Just a small fix for a bug that was already there before your PR.
Related Issue
Closes #116
Does this introduce a breaking change?
Other Information
This PR introduces the use of
digest
to compute thenullifier
output signal instead of thepreimage
as specified in the #116.Note that the number of constraints for
NUMBER_OF_INPUTS = 1
is the same as in the previous implementation. As this number increases, the complexity of the circuit increases.The
@zk-kit/poseidon-proof
package will be updated accordingly.Todos
of inputs.
as a public signal.
<= 16).
'IC').