Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eddsa-proof package #127

Merged
merged 32 commits into from
Feb 10, 2024
Merged

Add eddsa-proof package #127

merged 32 commits into from
Feb 10, 2024

Conversation

vplasencia
Copy link
Collaborator

Related Issue

#105

Does this introduce a breaking change?

  • Yes
  • No

@vplasencia vplasencia marked this pull request as draft January 15, 2024 08:50
@vplasencia
refactor(circuits): add scope as a public signal in the circuit
f8cecde
@vplasencia
test(circuits): update eddsa-proof circuit test
60a3fa6
@vplasencia
refactor(circuits): rename private key -> secret
47aa6d1
@vplasencia
refactor(eddsa-proof): update contract and verification key
a988587
@vplasencia
refactor(eddsa-proof): update docs and tests
34adf20
@vplasencia
docs(eddsa-proof): update readme file
c8d0214
@vplasencia
docs(eddsa-proof): update readme file
661bbf2
@vplasencia
docs(eddsa-proof): update readme file
0eb7608
@vplasencia
docs(eddsa-proof): update readme file
19bbcc6
@vplasencia
docs(eddsa-proof): update readme file
df2ae90
@vplasencia
refactor(eddsa-proof): update zk artifacts
02cf40f
@vplasencia
docs(eddsa-proof): update benchmarks in the readme file
fbacdd1
@vplasencia
docs(eddsa-proof): update generate code example in readme file
262e7e4
@vplasencia
docs(eddsa-proof): update readme file
ab56843
@vplasencia
refactor(eddsa-proof): update wasm and zkey files path
db35ab2
@vplasencia
Merge branch 'main' into feat/eddsa-proof-package
2775d3d
@vplasencia
refactor(eddsa-proof): update artifacts url
9b6f59f
@vplasencia
refactor(eddsa-proof): update node artifact names
de2378c
@vplasencia
refactor(eddsa-proof): update zk artifacts
2762426
@vplasencia vplasencia marked this pull request as ready for review January 22, 2024 11:33
@0xjei
Copy link
Member

0xjei commented Jan 22, 2024 •
edited

scheduled review on Friday xD

cedoor
cedoor requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments and suggestions. Overall, LGTM! Great work 🔥

packages/circuits/circom/eddsa-proof.circom Outdated Show resolved Hide resolved
packages/eddsa-proof/README.md Outdated Show resolved Hide resolved
packages/eddsa-proof/eddsa-proofVerifier.sol Outdated Show resolved Hide resolved
packages/eddsa-proof/package.json Outdated Show resolved Hide resolved
packages/eddsa-proof/package.json Outdated Show resolved Hide resolved
packages/eddsa-proof/rollup.browser.config.ts Outdated Show resolved Hide resolved
packages/eddsa-proof/rollup.node.config.ts Outdated Show resolved Hide resolved
packages/eddsa-proof/src/generate.ts Outdated Show resolved Hide resolved
packages/eddsa-proof/src/get-snark-artifacts.node.ts Outdated Show resolved Hide resolved
0xjei
0xjei requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @vplasencia 🔥

Please, review the scope signal usage - everything else LGTM! 👍

packages/circuits/circom/eddsa-proof.circom Show resolved Hide resolved
@cedoor cedoor merged commit 3d4c042 into main Feb 10, 2024
2 checks passed
@cedoor cedoor deleted the feat/eddsa-proof-package branch February 10, 2024 15:40
@cedoor cedoor linked an issue Feb 10, 2024 that may be closed by this pull request
Create @zk-kit/eddsa-proof package (former poseidon-proof) #105
Closed
@cedoor cedoor mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

@0xjei 0xjei 0xjei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create @zk-kit/eddsa-proof package (former poseidon-proof)
3 participants
@vplasencia @0xjei @cedoor