Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecdh): implement ECDH circom circuit #130

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 20, 2024

Description

Implement a circom circuit that allows to generate a shared secret from a private key and a public key.

Does this introduce a breaking change?

  • Yes
  • No

@ctrlc03 ctrlc03 requested review from cedoor and 0xjei January 22, 2024 10:03
@ctrlc03 ctrlc03 changed the base branch from main to feat/maci-circuits January 22, 2024 10:54
@0xjei
Copy link
Member

0xjei commented Jan 22, 2024

scheduled review on Thursday

Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ctrlc03 🔥

Left some comments and suggestions! Let me know 😊

packages/circuits/tests/ecdh.test.ts Outdated Show resolved Hide resolved
packages/circuits/tests/ecdh.test.ts Outdated Show resolved Hide resolved
packages/circuits/circom/ecdh.circom Outdated Show resolved Hide resolved
packages/circuits/circom/circuits.json Outdated Show resolved Hide resolved
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'd just recommend using the anonymous components like @0xjei already did!

In general, LGTM 👍🏽

@ctrlc03 ctrlc03 merged commit e62d7be into feat/maci-circuits Jan 29, 2024
2 checks passed
@ctrlc03 ctrlc03 deleted the feat/ecdh-circuit branch January 29, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants