Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnpackElement circuit #163

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add UnpackElement circuit #163

merged 1 commit into from
Mar 5, 2024

Conversation

0xjei
Copy link
Member

@0xjei 0xjei commented Feb 13, 2024

Description

This PR adds the UnpackElement circom template. This circuit allows a single field element to be converted into multiple 50-bit elements.

Compared to the original version of MACI, Anonymous Components were used, resulting in DX improvement and small optimisation.

Related Issue(s)

see #131

Other information

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn prettier and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@0xjei 0xjei requested review from cedoor and ctrlc03 February 13, 2024 15:41
@0xjei 0xjei changed the base branch from feat/maci-circuits to main February 13, 2024 15:42
@0xjei 0xjei changed the base branch from main to feat/maci-circuits February 13, 2024 16:29
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!!

@0xjei 0xjei force-pushed the feat/unpack-circuit branch 2 times, most recently from 2738c0e to 0b5b5e4 Compare March 5, 2024 09:34
@0xjei 0xjei closed this Mar 5, 2024
@0xjei 0xjei reopened this Mar 5, 2024
@0xjei 0xjei requested a review from cedoor March 5, 2024 09:54
@0xjei
Copy link
Member Author

0xjei commented Mar 5, 2024

The test CI fails because the poseidon-proof zkeys have been updated and the verification keys do not match the new circuit model.

@0xjei 0xjei merged commit 545c40d into feat/maci-circuits Mar 5, 2024
2 of 4 checks passed
@0xjei 0xjei deleted the feat/unpack-circuit branch March 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants