feat: add safe comparators templates #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the safe comparators (
SafeLessThan
,SafeLessEqThan
,SafeGreaterThan
,SafeGreaterEqThan
) circom templates. These circuits are pretty much similar to the circomlib ones but they add a conversion of the inputs to compare to their bit representations to ensure they fit within 'n' bits (implicit range check).Compared to the original version of MACI, Anonymous Components were used, resulting in DX improvement and small optimisation.
Related Issue(s)
see #131
Other information
Checklist
yarn prettier
andyarn lint
without getting any errors