Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

make lookup cmd param optional and use Path to handle param path #115

Merged
merged 3 commits into from
Feb 7, 2023
Merged

make lookup cmd param optional and use Path to handle param path #115

merged 3 commits into from
Feb 7, 2023

Conversation

smtmfft
Copy link
Contributor

@smtmfft smtmfft commented Feb 6, 2023

Tiny refine.

@pinkiebell
Copy link
Contributor

@smtmfft Thank you for the contribution! Please run the linter and then we are good to go 👌

@coveralls
Copy link

coveralls commented Feb 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4110758129

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.005%
Totals Coverage Status
Change from base Build 4104273557: 0.0%
Covered Lines: 549
Relevant Lines: 631
💛 - Coveralls

@smtmfft
Copy link
Contributor Author

smtmfft commented Feb 7, 2023

@smtmfft Thank you for the contribution! Please run the linter and then we are good to go 👌

Thanks! Fixed

pinkiebell
pinkiebell approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@pinkiebell pinkiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinkiebell pinkiebell merged commit 2e92b6c into privacy-scaling-explorations:master Feb 7, 2023
@smtmfft smtmfft deleted the dummy-test branch February 7, 2023 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pinkiebell pinkiebell pinkiebell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smtmfft @pinkiebell @coveralls