Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExpCircuit to integration tests #1100

Closed
ed255 opened this issue Jan 23, 2023 · 3 comments · Fixed by #1295
Closed

Add ExpCircuit to integration tests #1100

ed255 opened this issue Jan 23, 2023 · 3 comments · Fixed by #1295
Assignees
@leolara
Labels
crate-integration-tests Issues related to the integration-tests workspace member good first issue Good for newcomers T-tech-debt Type: tech-debt generated or cleaned up
Milestone
tech-debt-1

Comments

@ed255
Copy link
Member

ed255 commented Jan 23, 2023

I just noticed that this circuit is missing in the integration tests

Depends on
@ed255 ed255 added the good first issue Good for newcomers label Jan 23, 2023
@roynalnaruto
Copy link
Collaborator

Since the padding logic for Exponentiation circuit is not yet done, shall we wait for privacy-scaling-explorations/zkevm-specs#359 and #1062 to be merged before adding it to the integration tests?

@ed255
Copy link
Member Author

ed255 commented Jan 24, 2023

Since the padding logic for Exponentiation circuit is not yet done, shall we wait for privacy-scaling-explorations/zkevm-specs#359 and #1062 to be merged before adding it to the integration tests?

Yes! We should wait :)

@roynalnaruto roynalnaruto mentioned this issue Feb 9, 2023
Merged
@ed255
Copy link
Member Author

ed255 commented Feb 14, 2023

Depends on #1148 because it refactors the integration tests a bit

@ed255 ed255 added crate-integration-tests Issues related to the integration-tests workspace member T-tech-debt Type: tech-debt generated or cleaned up labels Feb 14, 2023
@leolara leolara self-assigned this Feb 15, 2023
@ed255 ed255 added this to the tech-debt-1 milestone Feb 16, 2023
@leolara leolara mentioned this issue Mar 8, 2023
Merged
4 tasks
leolara added a commit that referenced this issue Mar 9, 2023
@leolara
ExpCircuit integration test (#1295)
ad87905 
### Description

ExpCircuit integration test

### Issue Link

Closes
#1100

### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Contents

- ExpCircuit integration test

### Rationale

For fun and profit

### How Has This Been Tested?

Running integration tests
SuccinctPaul pushed a commit to SuccinctPaul/zkevm-circuits that referenced this issue Feb 15, 2024
@lispc
upgrade halo2 to v1.1 mvlookup (privacy-scaling-explorations#1100)
67f702d 
* upgrade halo2 to v1.1 mvlookup

* clippy

* update lookup name

* Revert "update lookup name"

This reverts commit a152c79.

* upgrade halo2

* change some lookup names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leolara leolara

Labels
crate-integration-tests Issues related to the integration-tests workspace member good first issue Good for newcomers T-tech-debt Type: tech-debt generated or cleaned up
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
tech-debt-1
Development

Successfully merging a pull request may close this issue.

ExpCircuit integration test privacy-scaling-explorations/zkevm-circuits
3 participants
@leolara @roynalnaruto @ed255