Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Copy circuit benchmark #1695

Open
ChihChengLiang opened this issue Nov 29, 2023 · 0 comments
Open

Fix Copy circuit benchmark #1695

ChihChengLiang opened this issue Nov 29, 2023 · 0 comments
Labels
good first issue Good for newcomers T-bug Type: bug

Comments

@ChihChengLiang
Copy link
Collaborator

What command(s) is the bug in?

cargo test -p circuit-benchmarks --features benches bench_copy_circuit_prover -- --nocapture

Describe the bug

This is a follow-up for #1646 and #1686.

The benchmark for Copy circuit remains to be fixed.

Possible direction for investigation.

  • The number of copy events is carefully chosen. Investigate the generate_full_events_block function
  • Tweak block.circuits_params.max_rws and block.circuits_params.max_copy_rows

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

No response

@ChihChengLiang ChihChengLiang added the T-bug Type: bug label Nov 29, 2023
@ed255 ed255 added the good first issue Good for newcomers label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

2 participants