bus-mapping: Add call_id in StackOp and MemoryOp #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed255
added
the
crate-bus-mapping
github-actions
bot
added
T-opcode
ed255
force-pushed
the
feature/circuitinputbuilder9
branch
2 times, most recently
from
08f8e19
to
10e91cc
Compare
Rename TxAccessListStorageSlot to TxAccessListAccountStorage Rename GlobalCounter to RWCounter and gc to rwc
ed255
force-pushed
the
feature/circuitinputbuilder9
branch
from
10e91cc
to
71957ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename TxAccessListStorageSlot to TxAccessListAccountStorage
Rename GlobalCounter to RWCounter and gc to rwc
Since StackOp and MemoryOp now have the
call_idfield, I've added the helper functionspush_memory_opandpush_stack_opso that the correctcall_idis set automatically without requiring passing the value.I've also modified the style of the Ord implementations for the Ops to a more clean and explicit way.