Add dummy_gen_create_ops to avoid call stack empty panic
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
ed255
reviewed
Apr 28, 2022
There was a problem hiding this comment.
Overall looks good! Nevertheless, please take a look at how push_op_reversible already applies the write operations to the StateDB (and thus there's no need to do it before). For context, this change was done here https://github.com/appliedzkp/zkevm-circuits/pull/436/files#diff-a06662ad93069ff8d12d1029c92dd22ef395882417fc8daa8a292f582eded9deR812
han0110
force-pushed
the
feature/dummy-gen-create-ops
branch
from
c10b991
to
1536b64
Compare
CPerezz
force-pushed
the
feature/dummy-gen-create-ops
branch
from
8e26eda
to
d43c6d8
Compare
|
Just rebased and I think this is ready to be merged! Should we merge @han0110 ? Or is there anything left you want to do? |
|
Nothing left to do, let's merge it after CI is finished. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make
CircuitInputBuilderwork with trace containingCREATE*bydummy_gen_create_ops, which takes care of call stack and state db to enable the parsing.It also does:
Memory::read_wordto be able to read a word even thememory[offset..offset+32]is out of range (the same behavior of EVM), and we would want this behavior because the step of trace has the memory before expansion.dummy_gen_selfdestructed_op.With #440 implemented, we should be able create partially verified proof of all kinds of trace (hopefully) instead of panic.