Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Bump halo2 dep version to v2022_05_03 tag #490

Merged
merged 1 commit into from
May 3, 2022
Merged

update: Bump halo2 dep version to v2022_05_03 tag #490

merged 1 commit into from
May 3, 2022

Conversation

CPerezz
Copy link
Member

@CPerezz CPerezz commented May 3, 2022

Resolves: #487

  • Removes the patch for halo2_proofs as it was doing nothing at all. Since we use the original from git. The section should be [patch."git_repo_url"].

And it does not bring any benefits at least now.

@CPerezz CPerezz requested review from ed255, pinkiebell and a team as code owners May 3, 2022 12:54
@github-actions github-actions bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-keccak Issues related to the keccak workspace member crate-prover Issues related to the prover workspace member T-bench Type: benchmark improvements labels May 3, 2022
@ntampakas ntampakas added the benchmarks: EVM Triggers an EVM circuit benchmark label May 3, 2022
ed255
ed255 approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntampakas ntampakas removed the benchmarks: EVM Triggers an EVM circuit benchmark label May 3, 2022
@CPerezz
Copy link
Member Author

CPerezz commented May 3, 2022

@ntampakas said that the Benchmarking CI is back and working!

Merging then!

@CPerezz CPerezz merged commit 01ab9c6 into main May 3, 2022
@CPerezz CPerezz deleted the update_halo2 branch May 3, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed255 ed255 ed255 approved these changes

@pinkiebell pinkiebell Awaiting requested review from pinkiebell

Assignees
No one assigned
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-keccak Issues related to the keccak workspace member crate-prover Issues related to the prover workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use improved unsafe_setup function for local & CI benchmarks
3 participants
@CPerezz @ed255 @ntampakas