Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halo2 bump to v2022_05_09 #503

Merged
merged 2 commits into from
May 9, 2022
Merged

Halo2 bump to v2022_05_09 #503

merged 2 commits into from
May 9, 2022

Conversation

CPerezz
Copy link
Member

@CPerezz CPerezz commented May 9, 2022

Solves the performance issues required to merge #425

@CPerezz
change: Update halo2 version to halo2_v2022_05_09
cecc25f 
Due to the performance issues found with the `MockProver` at #425
a new tag for `halo2` has been released to patch it.
@CPerezz
Update Cargo.lock
017b43f
@CPerezz CPerezz requested review from ed255, pinkiebell and a team as code owners May 9, 2022 16:59
@github-actions github-actions bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-keccak Issues related to the keccak workspace member crate-prover Issues related to the prover workspace member T-bench Type: benchmark improvements labels May 9, 2022
@CPerezz CPerezz mentioned this pull request May 9, 2022
Merged
ed255
ed255 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CPerezz CPerezz merged commit 00d2dcb into main May 9, 2022
@CPerezz CPerezz deleted the halo2_v2022_05_09 branch May 9, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed255 ed255 ed255 approved these changes

@pinkiebell pinkiebell Awaiting requested review from pinkiebell

Assignees
No one assigned
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-keccak Issues related to the keccak workspace member crate-prover Issues related to the prover workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CPerezz @ed255