Add 1 more instance row for starting row #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2022 14:25
github-actions
bot
added
the
crate-zkevm-circuits
jonathanpwang
pushed a commit
to axiom-crypto/zkevm-circuits
that referenced
this pull request
Aug 1, 2023
…act (privacy-scaling-explorations#544) * feat: refactor pi circuit to latest (wip) * do not include parent_hash in block table * pi circuit tests reorg * move constants to params * use copy constraints to enforce pi fields' validity * add rpi_padding related constraints * update dummy_tx to be pre-eip155 tx * finish rpi padding constraints * update keccak inputs for pi circuit * update (chain_id, hi, lo) instance into bytes * fmt * chain_id is u64 now * copy chain_id from pi to tx table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were short one instance row, which meant that the powers of randomness for the final row in the rw table were all 0.
The
storage_key_rlctest fails without the fix in theinstancefunction.