Refactor MulAddWordsGadget
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
davidnevadoc
force-pushed
the
refactor/MulAddWordsGadget
branch
from
9eadd87
to
937e54a
Compare
ed255
reviewed
Jun 2, 2022
icemelon
reviewed
Jun 4, 2022
The words `a, b, c, d` are now passed as arguments in `construct` instead of being fetched via `query_word()`.
- Move `assignment` out of `MulAddWordsGadget` - Consistent arguments for `construct` and `assign`
CPerezz
force-pushed
the
refactor/MulAddWordsGadget
branch
from
444cf99
to
8e16874
Compare
davidnevadoc
added a commit
to davidnevadoc/zkevm-circuits
that referenced
this pull request
Jun 8, 2022
* Refactor `MulAddWordsGadget` The words `a, b, c, d` are now passed as arguments in `construct` instead of being fetched via `query_word()`. * Address review comments - Move `assignment` out of `MulAddWordsGadget` - Consistent arguments for `construct` and `assign` * Store `words` in `MulDivModGadget` instead
jonathanpwang
pushed a commit
to axiom-crypto/zkevm-circuits
that referenced
this pull request
Aug 1, 2023
* Add trace dumper test that shows mpt enter invalid state * Add test for both code hashes changed * Add example from reading balance * Change default of AccountData to be all zeros * Add method for fill_state_roots_from_generator * Add balance traces * Add trace generators for code related tags * Use bigger value for balance * Add more storage trace dumpers * Add empty storage trace dumps * try * fix build * fixing * Remove generic F * Use update mpt circuit and re-order tags so that only nonce and balance updates can create accounts in the mpt * Handle case of an empty account for an empty storage proof * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * re-integration of mpt circuit * retain most generic in supercircuit * update cargo and fix post-merge * wip * wip * wip * Write empty keccak code hash when transfering to empty account. * wip * wip * wip * wip * wip * merge develop * Fix compile issues (privacy-scaling-explorations#550) * purge accident added file * apply new poseidon dep * update all poseidon table dep * lint * lint * Remove dbg's * Lookup mpt table entries in mpt circuit * cleanup * upgrade zktrie circuit * fmt * upgrade circuits * fix build * Use max_mpt_row instead of max_evm_row `max_evm_row` is not set in unittest, it cause some test failed * fix merge * clean deps * upgrade zktrie circuit * ignore some tests * fmt * disable mpt lookup temporarily * fix * fix * add the scroll-trace feature * fix * misc fixes * fix * clean --------- Co-authored-by: Mason Liang <mason@scroll.io> Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com> Co-authored-by: Ho Vei <noelwei@gmail.com> Co-authored-by: Ho <noel.wei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The words
a, b, c, dare now passed as arguments inconstructinstead of being fetched viaquery_word().Closes #547