Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Exp Circuit padding strategy #419

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

ed255
Copy link
Member

@ed255 ed255 commented May 8, 2023

This is #359 updated to resolve conflicts.

Implements the padding strategy for the Exp Circuit that doesn't require new constraints by adding dummy valid single-step exponentiation to fill the circuit.

added python spec code and added is_final col

fixed lint errors

added padding 1^1

nit changes

convert steps -> rows and removed pad_rows

fixed typing issue
@ed255 ed255 requested a review from CPerezz May 8, 2023 09:14
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ed255 ed255 merged commit 0da1195 into master May 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants