Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DuckDuckGo description and logos #1132

Merged
merged 1 commit into from Apr 29, 2022
Merged

Update DuckDuckGo description and logos #1132

merged 1 commit into from Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2022

polished up the duckduckgo recommendation a bit

@ghost ghost temporarily deployed to preview April 28, 2022 19:41 Inactive
@github-actions
Copy link

github-actions bot commented Apr 28, 2022 •
edited

🎊 PR Preview 269e932 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1132.surge.sh

🕐 Build time: 90.58s

🤖 By surge-preview

@ghost ghost changed the title Update DuckDuckGo Update DuckDuckGo description Apr 28, 2022
@ghost ghost marked this pull request as draft April 29, 2022 01:40
@ghost ghost temporarily deployed to preview April 29, 2022 01:45 Inactive
@ghost ghost changed the title Update DuckDuckGo description Update DuckDuckGo description and logos Apr 29, 2022
@ghost ghost temporarily deployed to preview April 29, 2022 01:52 Inactive
@ghost ghost temporarily deployed to preview April 29, 2022 02:06 Inactive
@ghost ghost marked this pull request as ready for review April 29, 2022 02:06
@dngray dngray added c:providers service providers and similar centralized/federated services t:correction content corrections or errors labels Apr 29, 2022
@dngray
Copy link
Member

dngray commented Apr 29, 2022

I'm thinking we should standardize canvas sizes of our SVGs https://github.com/privacyguides/privacyguides.org/wiki/Contributing#images

@ghost
Copy link
Author

ghost commented Apr 29, 2022

I'm thinking we should standardize canvas sizes of our SVGs https://github.com/privacyguides/privacyguides.org/wiki/Contributing#images

Does that matter when the css sets the size of them anyway?

@dngray dngray temporarily deployed to preview April 29, 2022 03:48 Inactive
@dngray
Copy link
Member

dngray commented Apr 29, 2022

Does that matter when the css sets the size of them anyway?

Probably not too much, but I like to scour them anyway.

@dngray
Update DuckDuckGo description and logos (#1132)
269e932 
Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray temporarily deployed to preview April 29, 2022 03:51 Inactive
@dngray dngray merged commit 269e932 into privacyguides:main Apr 29, 2022
@ghost
Copy link
Author

ghost commented Apr 29, 2022

Probably not too much, but I like to scour them anyway.

I always run them through svgomg, is that bad?

@elitejake
Copy link
Contributor

We should create an action to automatically scour SVGs.

@ghost
Copy link
Author

ghost commented Apr 29, 2022

Not a bad idea. GitHub Explore uses ImgBot and they also use a linter bot.

maybe something for @jonaharagon to look into

@elitejake
Copy link
Contributor

Does Imgbot minify SVGs?

@ghost
Copy link
Author

ghost commented Apr 29, 2022 •
edited by ghost

Does Imgbot minify SVGs?

Yes there is a svg in the example screenshot

@jonaharagon jonaharagon mentioned this pull request May 2, 2022
Merged
@ghost ghost deleted the duckduckgo-update branch May 2, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c:providers service providers and similar centralized/federated services t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dngray @elitejake