Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Yattee to "Frontends" #1955

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Adds Yattee to "Frontends" #1955

merged 1 commit into from
Feb 14, 2023

Conversation

jacobgonzales20
Copy link
Contributor

@jacobgonzales20 jacobgonzales20 commented Jan 26, 2023

Adds Yattee to "Frontends"

Note:

I'm unable to upload .svg, so currently I've set the logo to the remote GitHub URL to pull the image from. This can be changed by someone who has higher permissions.

- closes #1954 and #457

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute your contribution as part of our project.
  • Please check this box to confirm you are the sole author of this work, or that any additional authors will also reply to this PR on GitHub confirming their agreement to these terms.

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit b0ce8ce
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/63ebb24a5688790008f56853
😎 Deploy Preview https://deploy-preview-1955--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost ghost self-assigned this Feb 3, 2023
@ghost ghost added the c:software self-hosted/decentralized software and related topics label Feb 3, 2023
@ghost
Copy link

ghost commented Feb 3, 2023

I downloaded Yattee to try it out and it's not loading any videos for me for some reason.

@jacobgonzales20
Copy link
Contributor Author

jacobgonzales20 commented Feb 4, 2023

I downloaded Yattee to try it out and it's not loading any videos for me for some reason.

You need to add a piped or invidious instance to custom locations

Here's two of my guides on it, I have published
https://gonzoknows.com/posts/Yattee/
https://gonzoknows.com/posts/Best-Yattee-Custom-Locations/

@jacobgonzales20
Copy link
Contributor Author

I downloaded Yattee to try it out and it's not loading any videos for me for some reason.

Also, I would currently recommend using piped instances as invidious recently updated their API so Yattee still has to push an update as shown in this issue
yattee/yattee#391

@ghost
Copy link

ghost commented Feb 4, 2023

Thanks, I got it to work with your guide. Might link to that if that's ok with you, it's very helpful.

@jacobgonzales20
Copy link
Contributor Author

Thanks, I got it to work with your guide. Might link to that if that's ok with you, it's very helpful.

Definitely! I would appreciate that a lot, thanks.

@ghost ghost marked this pull request as draft February 4, 2023 05:22

!!! recommendation

![Yattee logo](https://camo.githubusercontent.com/5acbbe712241861ba5c9fd0011e702f577b661f499f1fc7ffbcca32f37f4320c/68747470733a2f2f722e7961747465652e73747265616d2f69636f6e732f7961747465652d3135302e706e67){ align=right }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do third party images for the logo.

Is there a SVG image of this logo?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find one yet, that's why it's still a draft. Was meaning to ask the dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've emailed the main developer, maybe they will have one for us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do third party images for the logo.

Is there a SVG image of this logo?

Yea, I was unable to locate an SVG. So I placed a temp URL till one is uploaded

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't have this logo in SVG. What is more is that Apple has problem with it and was rejecting some App Store submissions with it so I will need to change it to something else.

I can let you know once I have a new logo in SVG in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't have this logo in SVG. What is more is that Apple has problem with it and was rejecting some App Store submissions with it so I will need to change it to something else.

I can let you know once I have a new logo in SVG in the future.

Thank you, once you have a .svg feel free to add it to this thread or email back a copy

Copy link
Member

@dngray dngray Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arekf

I recreated your logo as a SVG, was simple enough, looks pretty close to the original except maybe for the fillet radius on the outer object:

svg

Here's the SVG

yattee

Least it should be easy enough to find out what about it is bothering Apple.

@dngray dngray marked this pull request as ready for review February 14, 2023 15:47
docs/tools.en.md Outdated Show resolved Hide resolved
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you reverted the fix

Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit b0ce8ce into privacyguides:main Feb 14, 2023
@arekf
Copy link

arekf commented Feb 14, 2023

Thanks to everyone for featuring Yattee on Privacy Guides ☺️ Especially to @dngray for taking effort to replicate the logo in SVG.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v2-33/11842/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Yattee - Privacy oriented video player for iOS, tvOS and macOS to "Frontends"
6 participants