Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording on Firefox sync #1198

Merged
2 commits merged into from
May 12, 2022
Merged

Fix wording on Firefox sync #1198

2 commits merged into from
May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2022

Resolves: #1196

"it should be safe to use" makes it sound like we're unsure about recommending it. Removed this part so it is shorter and more confident.

@ghost ghost temporarily deployed to preview May 11, 2022 18:49 Inactive
@github-actions
Copy link

github-actions bot commented May 11, 2022

🎊 PR Preview 73a874e has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1198.surge.sh

🕐 Build time: 87.483s

🤖 By surge-preview

@@ -98,7 +98,7 @@ This prevents you from unintentionally connecting to a website in plain-text HTT

#### Sync

[Firefox Sync](https://hacks.mozilla.org/2018/11/firefox-sync-privacy/) allows your browsing data (history, bookmarks, etc.) to be accessible on all your devices. It is fully E2EE, so it should be safe to use.
[Firefox Sync](https://hacks.mozilla.org/2018/11/firefox-sync-privacy/) allows your browsing data (history, bookmarks, etc.) to be accessible on all your devices. It is fully E2EE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is fully E2EE." to me, sounds a bit weird, maybe somehow "integrate" that into the previous sentence?

Something like

... to be accessible on all your devices while using E2EE.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, maybe "Firefox Sync allows your browsing data (history, bookmarks, etc.) to be accessible on all your devices and protects it with E2EE."

@ghost ghost temporarily deployed to preview May 12, 2022 05:50 Inactive
Copy link
Contributor

@subatomic-honda-civic subatomic-honda-civic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Honda Civic Approved 👍

Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6b760d2 into main May 12, 2022
@ghost ghost deleted the pr-syncfix branch May 12, 2022 11:50
@dngray dngray added c:software self-hosted/decentralized software and related topics t:correction content corrections or errors labels May 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange Wording for Firefox Sync
3 participants