Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the instructions more consistent in the browser section #1204

Merged
1 commit merged into from
May 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022

The configuration guides for the browser section were inconsistent so I fixed it.

@ghost ghost temporarily deployed to preview May 12, 2022 05:14 Inactive
@github-actions
Copy link

github-actions bot commented May 12, 2022

🎊 PR Preview 2ab86d2 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1204.surge.sh

🕐 Build time: 91.561s

🤖 By surge-preview

@@ -60,7 +60,7 @@ These options can be found in :material-menu: → **Settings** → **Privacy & S

##### Enhanced Tracking Protection

- [x] Enable **Strict** Enhanced Tracking Protection
- [x] Select **Strict** Enhanced Tracking Protection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using "Disable" in place of "Uncheck", maybe perhaps use "Enable" instead of "Select"? (Select/Disable or Enable/Disable)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using enable/disable for toggles, Select for those bulletpoint menu things, and check/uncheck for checkboxes. I thought "Select" made more sense for that option sense you have to select one of the options, you can't enable/disable it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using enable/disable for toggles, Select for those bulletpoint menu things, and check/uncheck for checkboxes. I thought "Select" made more sense for that option sense you have to select one of the options, you can't enable/disable it.

Makes more sense, my last brain cells were probably failing already 😄

Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit fc338ea into main May 12, 2022
@ghost ghost deleted the pr-mobilebrowserfix branch May 12, 2022 11:51
@dngray dngray added c:software self-hosted/decentralized software and related topics t:correction content corrections or errors labels May 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants